Expose new algorithms to create a Feature Policy before document is c…#324
Merged
clelland merged 3 commits intow3c:masterfrom Jul 16, 2019
Merged
Expose new algorithms to create a Feature Policy before document is c…#324clelland merged 3 commits intow3c:masterfrom
clelland merged 3 commits intow3c:masterfrom
Conversation
…reated. Adjust algorithms so that the HTML spec will be able to create a feature policy before the document is created. Instead of creating the document first and then applying it afterwards. The document based algorithms will remain until the HTML spec is changed.
clelland
reviewed
Jul 12, 2019
Collaborator
clelland
left a comment
There was a problem hiding this comment.
I like this -- splitting up the creation from actually assigning to document is a good idea, and I hope that assigning can be done in HTML eventually, since that's where a document's policy is actually declared.
clelland
approved these changes
Jul 16, 2019
Collaborator
clelland
left a comment
There was a problem hiding this comment.
This looks good; one tiny nit remains, but otherwise I'm okay with merging this.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jul 18, 2019
Instead of delegating to the feature policy spec to initialize feature policy after the document is created, initialize feature policy first and pass it in while constructing the document. This uses w3c/webappsec-permissions-policy#324.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…reated.
Adjust algorithms so that the HTML spec will be able to create a feature
policy before the document is created. Instead of creating the document
first and then applying it afterwards. The document based algorithms
will remain until the HTML spec is changed.