Draft
Conversation
Collaborator
Author
|
I'm going to let this rest until the libjpeg-turbo decoder bugs are gone, but I still think there'll be a benefit to this. Btw, https://static-misc-3.glitch.me/slow-img-load/ lets you slow-load images (you can select multiple) |
jakearchibald
commented
May 25, 2021
| scanptr->Se = 63; | ||
| scanptr->Ah = 1; | ||
| scanptr->Al = 0; | ||
| scanptr++; |
Collaborator
Author
There was a problem hiding this comment.
I'll extract these into a little helper function once we've got the output looking right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These progressive steps appear to play better with the DCT smoothing currently in Firefox and Chrome. However, I think there's a decoder bug right now, so it's possible we might not need this.
Or, maybe it should be upstreamed to MozJPEG itself?